input data config ignored in local mode?

[yifeim]

The local image clearly ignores context_type of an input,

sagemaker-python-sdk/src/sagemaker/local/image.py

Line 246 in 385d40a

json_input_data_config = {

despite they somehow passed unit test

sagemaker-python-sdk/tests/unit/test_local_session.py

Line 328 in c8006fa

def test_file_input_content_type():

My same custom model runs in remote but not in local. This inspires my question: how are context types detected? E.g., by file suffix?

Thanks.

[nadiaya]

Thank you for reporting it. This does look like a bug.

[iquintero]

Hi @yifeim this is fixed in #449

Local Mode will now work the same way as SageMaker does. Basically if you provide a content_type it will be passed to inputdataconfig.json. If you don't then there will be no ContentType key in the json file. It is up to your algorithm to define a default if it needs to. This change makes it consistent with SageMaker.

[yifeim]

Thanks a lot for the fast response! Will take a look.

…

On Fri, Nov 2, 2018 at 2:52 PM Ignacio Quintero ***@***.***> wrote: Hi @yifeim <https://github.com/yifeim> this is fixed in #449 <#449> Local Mode will now work the same way as SageMaker does. Basically if you provide a content_type it will be passed to inputdataconfig.json. If you don't then there will be no ContentType key in the json file. It is up to your algorithm to define a default if it needs to. This change makes it consistent with SageMaker. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#451 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIiQ6uW6gsxpNsScwozfMOylPOhttmG0ks5urL6xgaJpZM4YEs2I> .

[nadiaya]

Fixed has been merged. Resolving.

[yifeim]

Good job! The other changes are also interesting. Thanks a lot!