fix: usuability update from feedback - #6150
Merged
zhaoqizqwang merged 2 commits intoAug 4, 2026
Merged
Conversation
amazeAmazing
reviewed
Aug 4, 2026
|
|
||
| **AWS Console** | ||
|
|
||
| 1. Open your topic → **Access policy** tab → **Edit** |
Contributor
There was a problem hiding this comment.
Recommend:
1. Go to **Amazon SNS** → **Topics** -> open your topic -> → **Access policy** tab → **Edit**
Collaborator
Author
There was a problem hiding this comment.
Updated in the new commit
amazeAmazing
reviewed
Aug 4, 2026
| "Effect": "Allow", | ||
| "Principal": {"Service": "events.amazonaws.com"}, | ||
| "Action": "SNS:Publish", | ||
| "Resource": "arn:aws:sns:us-east-1:123456789012:my-training-alerts", |
Contributor
There was a problem hiding this comment.
Recommend calling out that the Resource and AWS:SourceAccount should match the SNS topic they created and their AWS account ID
Collaborator
Author
There was a problem hiding this comment.
Updated in the new commit
amazeAmazing
reviewed
Aug 4, 2026
| { | ||
| "Effect": "Allow", | ||
| "Action": "sns:GetTopicAttributes", | ||
| "Resource": "arn:aws:sns:*:*:my-training-alerts" |
Contributor
There was a problem hiding this comment.
Recommend calling out that this needs to match the created topic
amazeAmazing
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small usability improvement based on recent feedback
num_linetotail_linesinstream_logsinstance_countvalues