Skip to content

Fix tests in trainers #6169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsareddy0329 merged 1 commit into from
Aug 8, 2026
+3 −3
Merged

Fix tests in trainers #6169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sagemaker-train/tests/unit/train/test_dpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ def test_train_passes_sequence_length_to_serverless_config(self, mock_training_j
mock_get_role, mock_get_options, mock_resolve_model):
mock_validate_group.return_value = "test-group"
mock_resolve_model.return_value = ("test-model", "test-model")
mock_get_sagemaker_session.return_value = Mock()
mock_get_sagemaker_session.return_value = Mock(sagemaker_config={})
mock_fine_tuning_options = Mock()
mock_fine_tuning_options.to_dict.return_value = {}
mock_get_options.return_value = (mock_fine_tuning_options, "model-arn", False)
Expand Down
2 changes: 1 addition & 1 deletion sagemaker-train/tests/unit/train/test_rlvr_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ def test_train_passes_sequence_length_to_serverless_config(self, mock_training_j
mock_get_role, mock_get_options, mock_resolve_model):
mock_validate_group.return_value = "test-group"
mock_resolve_model.return_value = ("test-model", "test-model")
mock_get_sagemaker_session.return_value = Mock()
mock_get_sagemaker_session.return_value = Mock(sagemaker_config={})
mock_fine_tuning_options = Mock()
mock_fine_tuning_options.to_dict.return_value = {}
mock_get_options.return_value = (mock_fine_tuning_options, "model-arn", False)
Expand Down
2 changes: 1 addition & 1 deletion sagemaker-train/tests/unit/train/test_sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ def test_train_passes_sequence_length_to_serverless_config(self, mock_training_j
mock_get_role, mock_get_options, mock_resolve_model):
mock_validate_group.return_value = "test-group"
mock_resolve_model.return_value = ("test-model", "test-model")
mock_get_sagemaker_session.return_value = Mock()
mock_get_sagemaker_session.return_value = Mock(sagemaker_config={})
mock_fine_tuning_options = Mock()
mock_fine_tuning_options.to_dict.return_value = {}
mock_get_options.return_value = (mock_fine_tuning_options, "model-arn", False)
Expand Down