Implement isPrimaryKey check, fix and refactor check tests#250
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
No issues found. Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: 8c93b14f) — may not be fully accurate. Reply if this doesn't help. |
nikie
force-pushed
the
checks-isPrimaryKey-n-tests
branch
from
f2d12df to
167f3e2
Compare
|
No issues found. Generated by AI (model: us.anthropic.claude-opus-4-6-v1, prompt: 8c93b14f) — may not be fully accurate. Reply if this doesn't help. |
sudsali
approved these changes
May 7, 2026
sudsali
added a commit
that referenced
this pull request
Jul 7, 2026
Ships the stranded library features (rowLevelResultsAsDataFrame #262, isPrimaryKey #250, StringColumnProfile #248) as 1.6.0, and adds automated PyPI publishing modeled on awslabs/deequ's Secrets-Manager + OIDC flow. publish.yml: - Real upload happens ONLY on a v* tag push AND after the pypi-release environment's required reviewer approves. The OIDC role trust is bound to that environment (sub=repo:awslabs/python-deequ:environment:pypi-release), so a bare tag push by any collaborator cannot mint the token or upload without human sign-off. workflow_dispatch is build-only (never publishes). - Guards that the git tag matches the pyproject version. - PyPI token fetched at run time from Secrets Manager (pypi_token) and passed to Poetry via POETRY_PYPI_TOKEN_PYPI env — masked, never on argv, never in $GITHUB_OUTPUT or a file. --skip-existing for idempotent retries. Also: bump version 1.5.0 -> 1.6.0, sync pydeequ/__init__.py __version__ (was stale at 1.2.0), refresh the frozen README Announcements section.
sudsali
added a commit
that referenced
this pull request
Jul 7, 2026
Ships the stranded library features (rowLevelResultsAsDataFrame #262, isPrimaryKey #250, StringColumnProfile #248) as 1.6.0, and adds automated PyPI publishing modeled on awslabs/deequ's Secrets-Manager + OIDC flow. publish.yml: - Real upload happens ONLY on a v* tag push AND after the pypi-release environment's required reviewer approves. The OIDC role trust is bound to that environment (sub=repo:awslabs/python-deequ:environment:pypi-release), so a bare tag push by any collaborator cannot mint the token or upload without human sign-off. workflow_dispatch is build-only (never publishes). - Guards that the git tag matches the pyproject version. - PyPI token fetched at run time from Secrets Manager (pypi_token) and passed to Poetry via POETRY_PYPI_TOKEN_PYPI env — masked, never on argv, never in $GITHUB_OUTPUT or a file. --skip-existing for idempotent retries. Also: bump version 1.5.0 -> 1.6.0, sync pydeequ/__init__.py __version__ (was stale at 1.2.0), refresh the frozen README Announcements section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#249
Description of changes:
isPrimaryKeycheck implementation.tests/test_checks.pyare fixed and refactored as follows:pytest.mark.xfailmarks are removed (according to pytest docs they are meant for cases when feature is not yet implemented or there is a new bug which cannot be fixed yet; also with such marks on tests with multiple asserts it is not obvious which asserts are supposed to fail);"Success"and"Failure"checks are rearranged so that the former are grouped intest_<check>and the latter - intest_fail_<check>methods;run_checkhelper to simplify check tests;By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.