Skip to content

Add a span to indicate if java detector has started or finished #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haoozhang merged 1 commit into from
Nov 4, 2024
Merged

Add a span to indicate if java detector has started or finished #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cli/azd/internal/appdetect/java.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import (
"context"
"encoding/xml"
"fmt"
"github.com/azure/azure-dev/cli/azd/internal/tracing"
"github.com/azure/azure-dev/cli/azd/internal/tracing/fields"
"github.com/azure/azure-dev/cli/azd/pkg/osutil"
"github.com/braydonk/yaml"
"io/fs"
Expand All @@ -27,6 +29,7 @@ func (jd *javaDetector) Language() Language {
func (jd *javaDetector) DetectProject(ctx context.Context, path string, entries []fs.DirEntry) (*Project, error) {
for _, entry := range entries {
if strings.ToLower(entry.Name()) == "pom.xml" {
tracing.SetUsageAttributes(fields.AppInitJavaDetect.String("start"))
pomFile := filepath.Join(path, entry.Name())
project, err := readMavenProject(pomFile)
if err != nil {
Expand Down Expand Up @@ -58,6 +61,7 @@ func (jd *javaDetector) DetectProject(ctx context.Context, path string, entries
return nil, fmt.Errorf("detecting dependencies: %w", err)
}

tracing.SetUsageAttributes(fields.AppInitJavaDetect.String("finish"))
return result, nil
}
}
Expand Down
3 changes: 3 additions & 0 deletions cli/azd/internal/tracing/fields/fields.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@ const (
AppInitModifyAddCount = attribute.Key("appinit.modify_add.count")
AppInitModifyRemoveCount = attribute.Key("appinit.modify_remove.count")

// AppInitJavaDetect indicates if java detector has started or finished
AppInitJavaDetect = attribute.Key("appinit.java.detect")

// The last step recorded during the app init process.
AppInitLastStep = attribute.Key("appinit.lastStep")
)
Expand Down