Switch to avm for mysql#11
Merged
Merged
Conversation
rujche
commented
Nov 4, 2024
| var mysqlDatabaseName = '{{ .DbMySql.DatabaseName }}' | ||
| var mysqlDatabaseUser = 'mysqladmin' | ||
| {{- if (and .DbMySql .DbMySql.AuthUsingManagedIdentity) }} | ||
| module mysqlIdentity 'br/public:avm/res/managed-identity/user-assigned-identity:0.2.1' = { |
Author
There was a problem hiding this comment.
The identity is only required for MySql.
Refs:
- https://learn.microsoft.com/en-us/cli/azure/containerapp/connection/create?view=azure-cli-latest#az-containerapp-connection-create-postgres-flexible(serviceconnector-passwordless)
- https://learn.microsoft.com/en-us/cli/azure/containerapp/connection/create?view=azure-cli-latest#az-containerapp-connection-create-mysql-flexible(serviceconnector-passwordless)
rujche
commented
Nov 4, 2024
| azCliVersion: '2.63.0' | ||
| location: location | ||
| managedIdentities: { | ||
| userAssignedResourcesIds: [ |
Author
There was a problem hiding this comment.
Here, it is "userAssignedResourcesIds"
rujche
commented
Nov 4, 2024
| highAvailability: 'Disabled' | ||
| {{- if (and .DbMySql .DbMySql.AuthUsingManagedIdentity) }} | ||
| managedIdentities: { | ||
| userAssignedResourceIds: [ |
Author
There was a problem hiding this comment.
Here, it is userAssignedResourceIds
rujche
commented
Nov 4, 2024
| location: location | ||
| managedIdentities: { | ||
| userAssignedResourcesIds: [ | ||
| connectionCreatorIdentity.outputs.resourceId |
Author
There was a problem hiding this comment.
I considered using principalId which already exists in the line 16 of current file instead of creating connectionCreatorIdentity. It won't work because here in br/public:avm/res/resources/deployment-script, it only supports managedIdentities, but principalId can be Id of the user or app to assign application roles, it can be a user, not a managed identity.
saragluna
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested the following 4 cases: