Skip to content

Skip TestCreateSimulatedEffectivePom only when java command not exist #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rujche wants to merge 4 commits into from
Closed

Skip TestCreateSimulatedEffectivePom only when java command not exist #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73c8ecf
Skip TestCreateSimulatedEffectivePom only when java command not exist
rujche Dec 27, 2024
98fe2b9
Add "-v" when run "go test".
rujche Dec 27, 2024
43d2938
Fix type.
rujche Dec 27, 2024
24b7dfc
Add more information about checking "java" command.
rujche Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/go-test-for-sjad-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ jobs:
- name: Run tests
run: |
cd ./cli/azd
go test $(go list ./... | grep -v github.com/azure/azure-dev/cli/azd/test/functional) -cover
go test $(go list ./... | grep -v github.com/azure/azure-dev/cli/azd/test/functional) -cover -v
15 changes: 13 additions & 2 deletions cli/azd/internal/appdetect/pom_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,22 @@
package appdetect

import (
"log/slog"
"os"
"os/exec"
"path/filepath"
"reflect"
"strings"
"testing"
)

func TestCreateEffectivePom(t *testing.T) {
if !commandExistsInPath("java") {
t.Skip("Skip TestCreateEffectivePom because java command doesn't exist.")
} else {
path, _ := exec.LookPath("java")
slog.Info("Java command found.", "path", path)
}

@rujche rujche Dec 27, 2024

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI:
https://github.com/azure-javaee/azure-dev/actions/runs/12514686054/job/34911134938?pr=98#step:5:703

image

tests := []struct {
name string
testPoms []testPom
Expand Down Expand Up @@ -1053,8 +1061,11 @@ func TestAbsorbBuildPlugin(t *testing.T) {
}

func TestCreateSimulatedEffectivePom(t *testing.T) {
if os.Getenv("GITHUB_ACTIONS") == "true" {
t.Skip("Skip TestCreateSimulatedEffectivePom in GitHub Actions because it will time out.")
if !commandExistsInPath("java") {
t.Skip("Skip TestCreateSimulatedEffectivePom because java command doesn't exist.")
} else {
path, _ := exec.LookPath("java")
slog.Info("Java command found.", "path", path)
}
var tests = []struct {
name string
Expand Down