Skip to content

constant-folding: Fix some literal types used in .join(), closes #612 #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vigneshshanmugam merged 4 commits into from
Aug 15, 2017
+35 −26
Merged

constant-folding: Fix some literal types used in .join(), closes #612 #613

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff2d722
constant-folding: Fix some literal types used in `.join()`
goto-bus-stop Jul 2, 2017
f45656b
constant-folding: Handle simple template strings in `.join()`s
goto-bus-stop Jul 2, 2017
aa4f987
constant-folding: Use `path.evaluate()` on array elements.
goto-bus-stop Aug 15, 2017
c12a4af
Fix quote style
goto-bus-stop Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
constant-folding: Handle simple template strings in .join()s
  • Loading branch information
@goto-bus-stop
goto-bus-stop committed Aug 15, 2017
commit f45656b260e06a61fa1459c712a08487e8a703ad
2 changes: 2 additions & 0 deletions packages/babel-plugin-minify-constant-folding/__tests__/constant-folding-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ describe("constant-folding-plugin", () => {
[null, 1].join("/");
[/xyz/im, true].join("abc");
[\`a\${xyz}\`].join("1");
[\`a\`, \`c\`].join('b');

[1, 2, 3].length;
[1, 2, 3][1];
Expand Down Expand Up @@ -140,6 +141,7 @@ describe("constant-folding-plugin", () => {
"/1";
"/xyz/imabctrue";
[\`a\${xyz}\`].join("1");
"abc";

3;
2;
Expand Down
3 changes: 3 additions & 0 deletions packages/babel-plugin-minify-constant-folding/src/replacements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ module.exports = ({ types: t }) => {
) {
return el.value;
}
if (t.isTemplateLiteral(el) && el.expressions.length === 0) {
return el.quasis[0].value.cooked;
Copy link
Copy Markdown
Member

@vigneshshanmugam vigneshshanmugam Jul 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check this https://github.com/babel/babel/blob/7.0/packages/babel-traverse/src/path/evaluation.js#L391

}
bad = true;
return;
})
Expand Down