fix(pinpoint): restore click handler after exiting plan diff#238
Merged
backnotprop merged 1 commit intomainfrom Mar 7, 2026
Merged
fix(pinpoint): restore click handler after exiting plan diff#238backnotprop merged 1 commit intomainfrom
backnotprop merged 1 commit intomainfrom
Conversation
The pinpoint click effect read `highlighterRef.current` at effect setup time and bailed early if it was null. After exiting plan diff, the Viewer fully remounts — usePinpoint's click effect ran before the highlighter init effect, so `highlighterRef.current` was still null. The effect returned early without installing the click handler, and nothing triggered it to re-run since the dependencies (stable refs, unchanged `isActive`) didn't change. Move the highlighter read into the click handler body so it's resolved lazily at click time, when the highlighter is guaranteed to be ready. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usePinpointclick effect readhighlighterRef.currentat effect setup time and exited early if null. After exiting plan diff, theViewercomponent fully remounts —usePinpoint's click effect ran before the highlighter init effect (line 500), so the ref was stillnull. The effect bailed without installing the click handler, and nothing triggered a re-run since all dependencies (stable refs, unchangedisActive) remained the same.web-highlighter's own internal mouseup listener (set up duringhighlighter.run()), which is independent of theusePinpointhook.usePinpointdoesn't depend onhighlighterRef, so it continued functioning normally.Fix
Moved
highlighterRef.currentfrom effect setup time into the click handler body, so it's resolved lazily at click time when the highlighter is guaranteed to be initialized.Test plan
🤖 Generated with Claude Code