feat: Obsidian saving enhancements — separator, auto-save, sanitization#240
Merged
backnotprop merged 3 commits intomainfrom Mar 7, 2026
Merged
feat: Obsidian saving enhancements — separator, auto-save, sanitization#240backnotprop merged 3 commits intomainfrom
backnotprop merged 3 commits intomainfrom
Conversation
Strip parentheses, brackets, curly braces, hash, tilde, and backtick from plan titles when generating Obsidian filenames. Re-trim after stripping to handle edge cases where stripped chars leave leading/trailing whitespace. Closes part of #235. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Filename separator: adds a dropdown in Obsidian settings to replace spaces with dashes or underscores in generated filenames. Fixes issues with CLI tools fumbling space-escaped paths inside Obsidian vaults. The setting flows through the save request to generateFilename() as a post-processing step. Live preview reflects the choice. Auto-save on arrival: adds an opt-in toggle that automatically saves plans to Obsidian the moment they load in the browser, before the user approves or denies. This fixes the workflow where approving from the Claude Code CLI kills the hook server before the user can Cmd+S. Guarded by a ref to fire only once per session. Closes #235, closes #228. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
The ExportModal's save-to-Obsidian callsite was missing the filenameSeparator config, causing the separator preference to be silently ignored when saving via the Export Modal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
# My Plan (v2) [draft]— verify clean filenameCloses #235, closes #228.
🤖 Generated with Claude Code