chore: add options for resource requests for vault-agent#275
Conversation
dhumphries-sainsburys
requested review from
ramizpolic
and removed request for
a team
dhumphries-sainsburys
force-pushed
the
add_agent_resource_requests
branch
from
73e21eb to
59109ec
Compare
|
Hi @dhumphries-sainsburys, thanks for the contribution! I left a couple of notes to address and we can merge it afterwards. Please also include the docs for the new flags where appropriate. |
ramizpolic
left a comment
ramizpolic
left a comment
There was a problem hiding this comment.
Added a couple of notes, can merge after these are resolved. Thanks for the updates @dhumphries-sainsburys!
|
@ramizpolic - Think all changes are made but github UI seems to be showing something different to the commits so not entirely sure |
|
Linter seems to be complaining. If you could sign the commits and address the lint issue, we can merge this. Not sure why it's complaining though. |
Signed-off-by: Daniel.Humphries <daniel.humphries@sainsburys.co.uk>
dhumphries-sainsburys
force-pushed
the
add_agent_resource_requests
branch
from
187c582 to
1e8c11b
Compare
|
Squashed the commits as well as signed. In regards to the linter i couldn't find a problem and the error previous looked more like a problem with the linter rather than what it was linting to me |
Signed-off-by: Daniel.Humphries <daniel.humphries@sainsburys.co.uk>
ramizpolic
left a comment
ramizpolic
left a comment
There was a problem hiding this comment.
great work @dhumphries-sainsburys, thanks for the contribution!
…#275) * chore: add options for resource requests for vault-agent Signed-off-by: Daniel.Humphries <daniel.humphries@sainsburys.co.uk> * chore: include 'fixes' from linter Signed-off-by: Daniel.Humphries <daniel.humphries@sainsburys.co.uk> --------- Signed-off-by: Daniel.Humphries <daniel.humphries@sainsburys.co.uk>
2 participants
Currently the vault-agent takes a resource for requests and limits combined but in usage we see that startup usage is high and ongoing usage is low so we are faced with either large amounts of wasted resources across a cluster or a risk of OOM kills on startup. This PR will just allow requests and limits to be defined independently of each other