Skip to content

style: prefix cached bundle helper #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leopoldjoy merged 2 commits into from
Jul 31, 2026
Merged

style: prefix cached bundle helper #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
527bea6
style: prefix cached bundle helper
leopoldjoy Jul 24, 2026
d5443c1
Merge remote-tracking branch 'origin/main' into audit/prefix-cached-b…
leopoldjoy Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/NitroValidator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ contract NitroValidator {
cabundle[i] = attestationTbs.slice(ptrs.cabundle[i]);
}

ICertManager.VerifiedCert memory leafCert = verifyCachedCertBundle(cert, cabundle);
ICertManager.VerifiedCert memory leafCert = _verifyCachedCertBundle(cert, cabundle);
bytes memory hash = Sha2Ext.sha384(attestationTbs, 0, attestationTbs.length);
require(
p384Verifier.verifyP384SignatureWithHints(hash, signature, leafCert.pubKey, attestationSigHints),
Expand All @@ -175,7 +175,7 @@ contract NitroValidator {
/// record without re-checking the signature (and so needs no hints). If a cert is NOT
/// cached, signature verification is attempted against an empty hint stream and reverts
/// with "inverse hint underflow". Callers must therefore pre-cache the whole bundle first.
function verifyCachedCertBundle(bytes memory certificate, bytes[] memory cabundle)
function _verifyCachedCertBundle(bytes memory certificate, bytes[] memory cabundle)
internal
returns (ICertManager.VerifiedCert memory)
{
Expand Down
Loading