Fix ES module import extension #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The import of './common' was missing the .js extension, which is required in strict ES module environments. While TypeScript and development tools handle this gracefully, the compiled output fails when consumed by other ES module projects. This fixes the import to use './common.js' as required by ES module spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
./commonto./common.jsinaxios-client.tsProblem
The SDK was failing when consumed by other ES module projects because relative imports were missing the
.jsextension, which is required by ES module specification.Solution
Added
.jsextension to the relative import as required by ES modules.Test plan