Add ListAnswersByPerson to CheckinsService

[robzolkos]

Summary

The BC3 API supports GET /questions/{id}/answers/by/{personId}.json to fetch a specific person's answers to a check-in question, and the generated Go client already exposes GetAnswersByPersonWithResponse. However, the CheckinsService had no service-layer wrapper for it.

This PR adds ListAnswersByPerson(ctx, questionID, personID int64, opts *AnswerListOptions) (*AnswerListResult, error) to CheckinsService, following the same pagination pattern as the existing ListAnswers method.

Changes

• go/pkg/basecamp/checkins.go — new ListAnswersByPerson method on CheckinsService
• go/pkg/basecamp/checkins_test.go — TestCheckinsService_ListAnswersByPerson verifies path/method, plus a table-driven _Pagination test exercising multi-page collect, Page short-circuit, and limit truncation on both first page and mid-second-page (also retroactively covers ListAnswers's shared pagination path)
• spec/fixtures/checkins/answers_by_person.json — fixture for the answers-by-person list response
• scripts/check-service-drift.sh — drop the now-stale GetAnswersByPerson entry from EXCLUDED_OPS (this PR wraps it)

Naming

The method is ListAnswersByPerson rather than ListAnswersByUser to match upstream conventions: the Smithy spec defines GetAnswersByPerson, the Go generated client exposes GetAnswersByPersonWithResponse, the URL path is /by/{personId}, the parameter type is PersonId, and Ruby, Python, TypeScript, Kotlin, and Swift all use by_person/byPerson. "Person" is also the correct Basecamp domain term — it covers users, clients, employees, and vendors, all of whom can submit check-in answers.

Other languages

Ruby, Python, TypeScript, Kotlin, and Swift all already expose this endpoint — their SDKs are fully generated from the OpenAPI spec so byPerson/by_person was included from the start. The Go SDK is unique in having a hand-written service layer on top of the generated client, which is why only Go needed this change.

Context

This unblocks basecamp/basecamp-cli#443, which requests a --by filter on basecamp checkins answers. The CLI PR depends on this SDK method being available.

[github-actions]

Spec Change Impact

• Added operation: ListAnswersByUser in CheckinsService.
• Modified resources/types: None.
• Removed operations/types/resources: None.
• Breaking API change: No, this is a non-breaking change.

SDKs requiring updates:

• Go
• TypeScript
• Ruby
• Kotlin
• Swift

All SDKs need regeneration to incorporate the added operation.

[cubic-dev-ai]

No issues found across 3 files

[cubic-dev-ai]

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="go/pkg/basecamp/checkins.go">

<violation number="1" location="go/pkg/basecamp/checkins.go:521">
P1: Export the wrapper as `ListAnswersByUser` to match the requested SDK API; `ListAnswersByPerson` is the wrong public method name.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[Copilot]

Pull request overview

This PR adds a Go CheckinsService wrapper for the “answers by person” check-in endpoint so callers can list a specific person’s answers using the same pagination/limit pattern as existing answer listing helpers.

Changes:

• Add CheckinsService.ListAnswersByPerson(...) wrapper around the generated GetAnswersByPersonWithResponse operation, including limit + Link-header pagination handling.
• Add a service-level test and a new fixture for the single-person answers response.
• Update the service-drift script exclusions so GetAnswersByPerson is no longer treated as intentionally unwrapped.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
go/pkg/basecamp/checkins.go	Adds ListAnswersByPerson service wrapper with pagination/limit behavior and updates pagination docs.
go/pkg/basecamp/checkins_test.go	Adds a test verifying the correct endpoint path is called and the response is parsed.
spec/fixtures/checkins/answers_by_person.json	Adds fixture data for the “answers by person” list response.
scripts/check-service-drift.sh	Removes GetAnswersByPerson from the intentionally-unwrapped operation exclusions.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.