Skip to content

Merge #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bashkirtsevich merged 2 commits into from
Dec 27, 2018
Merged

Merge #1

bashkirtsevich merged 2 commits into from
Dec 27, 2018

Conversation

@bashkirtsevich
Copy link
Owner

@bashkirtsevich bashkirtsevich commented Dec 27, 2018

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

cheng-kang and others added 2 commits December 5, 2018 10:29
@cheng-kang @QingWei-Li
feat(search-plugin): add namespace option (#706)
28beff8 
* feat(search-plugin): add namespace option

* docs(search-plugin): update doc for option namespace
@bashkirtsevich @QingWei-Li
Fix getAndRemoveConfig regex (#708)
6ac7bac 
* Fix getAndRemoveConfig regex

Update getAndRemoveConfig regular expression for prevent cases, when header has name like "foo::bar::baz".

* Fix wrong regexp

* Fix regex

Ignore `:foo` cases
@bashkirtsevich bashkirtsevich changed the title Morge Merge Dec 27, 2018
@bashkirtsevich bashkirtsevich merged commit 4e93874 into bashkirtsevich:master Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bashkirtsevich @cheng-kang