Improve performance of slide histogram#2
Merged
slfritchie merged 1 commit intomasterfrom Dec 31, 2012
Merged
Conversation
Partition slide histogram reservoir by erlang:system_info(scheduler_id), as previously done with counter and spiral metrics.
Author
|
+1 to merge. Verification, using Erlang/OTP R15B02 or R15B03:
... where the On my MacBook Pro, I see the following runtimes omitted for steps 8 and steps 12:
That's about 4.3x faster, yay. |
slfritchie
added a commit
that referenced
this pull request
Dec 31, 2012
Improve performance of slide histogram
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch by @jtuple ... I'm just creating the pull request to get the review & merge show on the road....
Partition slide histogram reservoir by erlang:system_info(scheduler_id),
as previously done with counter and spiral metrics.