Skip to content

Use folsom for repl stats#59

Merged
russelldb merged 3 commits intomasterfrom
rdb-folsom-stats
Jun 7, 2012
Merged

Use folsom for repl stats#59
russelldb merged 3 commits intomasterfrom
rdb-folsom-stats

Conversation

@russelldb
Copy link
Contributor

@ghost ghost assigned russelldb May 24, 2012
@ghost ghost assigned buddhisthead May 31, 2012
@buddhisthead
Copy link
Contributor

when I add a listener to the replication master, the node crashes due to a bad function call:

2012-06-05 12:36:25.400 [error] <0.2302.0> gen_server riak_repl_leader_gs terminated with reason: bad argument in call to ets:update_counter(folsom_counters, {riak_repl,elections_leader_changed}, 1) in folsom_metrics_counter:inc/2 line 45

If I am not mistaken, there is a typo in ./deps/riak_repl/src/riak_repl_stats.erl.
"increment_counter(elections_leader_changed)." does not agree with "{elections_leader_change, counter}," by the very tiny single character "d"...change vs changed.

I changed the code to use elections_leader_changed consistently and that resolved the crash.

Add eunit tests for basic register / update / read stats
@russelldb
Copy link
Contributor Author

Added a commit and some much needed eunit tests.

@buddhisthead
Copy link
Contributor

+1 to merge. Good fix and unit tests. Thanks!

@ghost ghost assigned russelldb Jun 6, 2012
russelldb added a commit that referenced this pull request Jun 7, 2012
@russelldb russelldb merged commit 12b1e0c into master Jun 7, 2012
@seancribbs seancribbs deleted the rdb-folsom-stats branch April 1, 2015 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants