Conversation
…selection of operations in PosixMmapFile.
… log and others to use background.
… the call creates side effects.
…e SetForCompaction() in this code base (though not for an already open file).
There was a problem hiding this comment.
do you mean that this is a future TODO?
There was a problem hiding this comment.
yes. not in this branch.
There was a problem hiding this comment.
There is also a commented out posix_fadvise in env_posix.cc (line 119) that is related to this comment. There is a heavy interaction between the two that I do not have time to completely research at this time. Hence, bypassing both lines.
There was a problem hiding this comment.
just double checking that you intend to call NewWritableFile from inside NewWriteOnlyFile (or at least explain why in a comment, other than "derived from NewWritableFile")
There was a problem hiding this comment.
Comment was updated but is not reflected on this screen. See file's line-by-line diff to see new comment.
|
@matthewvon looks good, misc (non-critical) formatting issues. |
2 participants
This branch makes the posix_fadvise() calls more effective and fixes a race condition found in the file write operations. Branch notes are here: https://github.com/basho/leveldb/wiki/mv-sst-fadvise