Add optional bucket_type parameter for Map/Reduce#385
Conversation
|
Thanks @javajolt. I tested with your patch. So it seems working. It runs on bucket 'maps'/'cars', as expected. I'll continue to work with bucket_type map reduce and send more feedback. |
658127f to
89635c4
Compare
There was a problem hiding this comment.
This will always be true, but bucket.bucket_type.name might be "default". Even untyped buckets have a bucket type now.
There was a problem hiding this comment.
I suspect I actually mean the argument bucket_type instead of the bucket.bucket_type, i.e., the case where the user actually specified the bucket type. We could always take the bucket_type from the RiakBucketobject here or only add it to the M/R job iff the user explicitly adds it. That was my thought for safest backwards compatibility.
e030f30 to
c448c75
Compare
There was a problem hiding this comment.
c448c75 to
540ae75
Compare
|
👍 540ae75 |
Add optional `bucket_type` parameter for Map/Reduce Reviewed-by: seancribbs
|
@borshop merge |
It looks like support for bucket types were overlooked when the
riak-python-clientwas updated to version 2.1.0 to support Riak 2.0. This addresses issue #383.Essentially the
add()function now supports an optionalbucket_typeargument which will percolate down to the M/R JSON sent to Riak. If it is not supplied or isNoneit is assumed that thedefaultbucket type is being used.index()was also updated, butsearch()was not since it actually now uses Solr indexes instead of bucket types.