Skip to content

Atomically create a new RiakBucket to avoid race condition in duplication #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borshop merged 1 commit into from
Dec 18, 2014
+2 −6
Merged

Atomically create a new RiakBucket to avoid race condition in duplication #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions riak/client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,8 @@ def bucket(self, name, bucket_type='default'):
raise TypeError('bucket_type must be a string '
'or riak.bucket.BucketType')

if (bucket_type, name) in self._buckets:
return self._buckets[(bucket_type, name)]
else:
bucket = RiakBucket(self, name, bucket_type)
self._buckets[(bucket_type, name)] = bucket
return bucket
return self._buckets.setdefault((bucket_type, name),
RiakBucket(self, name, bucket_type))

def bucket_type(self, name):
"""
Expand Down