Fix PEP8 Warnings and Pass Tests with Riak 2.1.1#407
Merged
Conversation
- Limit links in test_index_timeout - Reduce the number of links in test_too_many_link_headers_shouldnt_break_http
|
Tests pass and code looks good. |
|
👍 aee07d1 |
borshop
added a commit
that referenced
this pull request
Jul 20, 2015
Fix PEP8 Warnings and Pass Tests with Riak 2.1.1 Reviewed-by: christophermancini
Author
|
@borshop merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PEP8 specification has been radically updated over the past few months which now includes the location of imports and the use of anonymous functions. The Python client needed to be reorganized to pass the
linttest. Because all of the imports need to be at the top of the file, a few classes needed to be pulled into their own files to help the changed order of import dependencies.Also now in Riak 2.1.1 two tests were modified to aid in passing:
test_too_many_link_headers_shouldnt_break_httpreduced the number of test links to 300 from 400test_index_timeoutalways has had flappy behavior since it's a timeout race condition. Needs to be removed or improved