READY: Add Timeseries support#416
Conversation
…tUp / tearDown into tests that use them.
There was a problem hiding this comment.
Why create a new class just for timeseries? Seems like you could create other classes for, say, datatypes to be consistent. Is there some special behavior here?
There was a problem hiding this comment.
I figured since TS isn't a real thing yet it would be nice to keep it separate and skippable.
There was a problem hiding this comment.
leave in logging? hmm
There was a problem hiding this comment.
Nice, but don't we already have a THANKS file?
There was a problem hiding this comment.
Ah! I'll move those here ... that's what @mjbrender has had us do with the other clients. I know one unit test reads the THANKS file so I'll address that.
- Clean up all PEP8 and pyflakes warnings
|
@lukebakken Since you were massively reworking the test infrastructure in this PR I took the liberty of getting rid of all of the Also, before it will pass buildbot's keen eye, you need to do a I was doing a regression test against a non-TS server to see how things worked and all is well except that HTTP security tests seem to be broken. I'll look at that later. I think I broke one security test, too, in cleaning things up. I'll return to that as well. It looks like Time Series kills the 2i tests. I know there is some code overlap, so perhaps that is to be expected. Also the actual Time Series tests seem to fail against the latest build of e2e/ts. |
|
Output from |
|
@lukebakken That's because it passes now. 😀 I cleaned up all of the warnings. |
|
@javajolt this is the first time I've run it ... did you have to make changes to get it to check out OK? |
|
Aha I'm assuming some of the whitespace / formatting changes in your commit. |
due to Python 3's in limitation on binary encoded strings. Also tweak a few version compatibility features and clean up PEP8/pyflakes warnings.
- Retire Python 2.6 - Swap 2.7.8 for 2.7.9 (PyOpenSSL version) - Add in Python 3.5.1
- Retire Python 2.6 - Swap 2.7.8 for 2.7.9 (PyOpenSSL version) - Add in Python 3.5.1
There was a problem hiding this comment.
I don't understand this requirement. If you have riak_pb in your PYTHONPATH, why do you have to have protobuf version 2.6.1? I assume if you had, say 2.5.0, surely that would work, too. Normally installing riak_pb from PyPI will get the required protobuf libraries. Also this will break with Python 3 which actually requires python3_protobuf instead.
There was a problem hiding this comment.
I found that it won't install protobuf for you if you're using PYTHONPATH to point to riak_pb. I haven't yet pushed a change that looks for riak_pb/python3/lib as well.
Without this code, you can't use PYTHONPATH to point to riak_pb. Of course, once #418 is merged none of this is necessary.
There was a problem hiding this comment.
As you say, this will soon go away. I guess I'd prefer just to manually manage your own dependencies for a manual install. Seems like a temporary requirement. Or we can rip this out as part of #418.
There was a problem hiding this comment.
Hmmm... Upon reflection, I think we could just add a protobuf dependency. Of course you'll need to do that in #418 anyway.
|
👍 57c47c0 |
READY: Add Timeseries support Reviewed-by: javajolt
|
@borshop merge |
3 participants
Also refactoring unit tests so that individual test suites can be run via the
--test-suiteargument:python2 setup.py test --test-suite=riak.tests.test_timeseriesThis involved removing the hackish Pbc and Http unit test classes that would switch protocols out underneath the test suite as well as making it impossible to run an individual suite. Instead, use the
RIAK_TEST_PROTOCOLenvironment variable to choose a protocol to test.Include a fix so that the
timeouttransport option is actually passed to the HTTP connection classes when instantiated.