Don't use six.PY2 in setup.py#459
Merged
Merged
Conversation
six is not guaranteed to be installed before running pip/setuptools.
The client fails to install on a machine or fresh virtualenv
without six with errors like the following:
```
; virtualenv ve
; ./ve/bin/pip install riak
Collecting riak
Downloading riak-2.5.0.tar.gz (193kB)
100% |████████████████████████████████| 196kB 9.2MB/s
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "<string>", line 20, in <module>
File "/tmp/pip-build-ReAmHf/riak/setup.py", line 4, in <module>
import six
ImportError: No module named six
```
This snuck past tox testing, because six is listed as an explict
dependency in tox.ini.
Contributor
|
@daroot thanks. I am facepalming. |
Contributor
|
#460 (CLIENTS-836) filed to prevent this from happening in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
six is not guaranteed to be installed before running pip/setuptools.
The client fails to install on a machine or fresh virtualenv
without six with errors like the following:
This snuck past tox testing, because six is listed as an explict
dependency in tox.ini.
I tried testing the changes locally, but ran into another six related problem in basho-erlastic, which I filed an issue for. basho/python-erlastic#2