-
Notifications
You must be signed in to change notification settings - Fork 185
Workaround for version returned by Riak TS OSS #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -78,7 +78,16 @@ def _get_codec(self, msg_code): | |
| # FeatureDetection API | ||
| def _server_version(self): | ||
| server_info = self.get_server_info() | ||
| return server_info['server_version'] | ||
| ver = server_info['server_version'] | ||
| (maj, min, patch) = [int(v) for v in ver.split('.')] | ||
| if maj == 0: | ||
| import datetime | ||
| now = datetime.datetime.now() | ||
| if now.year == 2016: | ||
| # GH-471 As of 20160509 Riak TS OSS 1.3.0 returns '0.8.0' as | ||
| # the version string. | ||
| return '2.1.1' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this impact the version-specified capabilities coming from the server?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure what you mean ... if we leave it at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Once this is fixed in riak it will come back as, say,
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, right now in |
||
| return ver | ||
|
|
||
| def ping(self): | ||
| """ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very short-term fix just until we merge KV/TS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep or until this gets fixed: basho/riak#835