Skip to content

Support multiple PB listeners#290

Merged
seancribbs merged 3 commits intomasterfrom
sdc-multiple-pb-listeners
Mar 16, 2013
Merged

Support multiple PB listeners#290
seancribbs merged 3 commits intomasterfrom
sdc-multiple-pb-listeners

Conversation

@seancribbs
Copy link
Contributor

@ghost ghost assigned russelldb Mar 15, 2013
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orelse PB == {ok, []} works for me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks, fixing.

@russelldb
Copy link
Contributor

Warning didn't appear for an entry of

{pb, []}

Comment above fixes that. Apart from that +1.

@russelldb
Copy link
Contributor

Yup, +1.

@ghost ghost assigned seancribbs Mar 16, 2013
seancribbs pushed a commit that referenced this pull request Mar 16, 2013
@seancribbs seancribbs merged commit b018003 into master Mar 16, 2013
@seancribbs seancribbs deleted the sdc-multiple-pb-listeners branch March 16, 2013 21:41
@jaredmorrow
Copy link
Contributor

@seancribbs this needs a patch / PR to basho/riak_ee as well.

@seancribbs
Copy link
Contributor Author

@jaredmorrow Roger, wilco

@seancribbs seancribbs removed their assignment May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants