Skip to content

Enable multiple PB listeners.#23

Merged
seancribbs merged 1 commit intomasterfrom
sdc-multiple-listeners
Mar 16, 2013
Merged

Enable multiple PB listeners.#23
seancribbs merged 1 commit intomasterfrom
sdc-multiple-listeners

Conversation

@seancribbs
Copy link

Works similarly to the http/https settings in riak_core. The previous settings, pb_ip and pb_port are now deprecated, and the legacy riak_kv settings are now removed/ignored.

@ghost ghost assigned seancribbs Feb 26, 2013
@ghost ghost assigned russelldb Mar 14, 2013
@russelldb
Copy link
Contributor

I get "Warning in app.config: pb_port undefined, protobuffs interface not enabled" when I use the following config:

{pb, [{"127.0.0.1", 8087}, {"10.0.0.12", 8073}]}

Apart from that, looks good, confirm it works, tests pass. Another PR for this fix (https://github.com/basho/riak/tree/riak_api23-pb-listeners) to nodetool?

@seancribbs
Copy link
Author

@russelldb Weird, I had no idea that even existed in nodetool. Thanks for finding it.

@ghost ghost assigned seancribbs Mar 16, 2013
seancribbs pushed a commit that referenced this pull request Mar 16, 2013
@seancribbs seancribbs merged commit f506a12 into master Mar 16, 2013
@seancribbs seancribbs deleted the sdc-multiple-listeners branch March 16, 2013 21:41
bookshelfdave pushed a commit to bookshelfdave/riak that referenced this pull request Dec 9, 2013
@seancribbs seancribbs removed their assignment May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants