Skip to content

Make sure all data types use configured compression in t2b/b2t#85

Merged
borshop merged 5 commits intodevelopfrom
bugfix/lenary/use-compression-everywhere
Apr 14, 2014
Merged

Make sure all data types use configured compression in t2b/b2t#85
borshop merged 5 commits intodevelopfrom
bugfix/lenary/use-compression-everywhere

Conversation

@lenary
Copy link
Copy Markdown
Contributor

@lenary lenary commented Apr 14, 2014

For 2.0 release (map and orswot currently use compression):

  • lwwreg (only ever in map, which never calls to_binary/1 in lwwreg)
  • od-flag (only ever in map, which never calls to_binary/1 in od-flag)
  • pn-counter (we've kinda looked at this, but compression might do better)

For later:

  • gcounter
  • gset
  • oe-flag
  • orset

@lenary lenary added this to the 2.0-RC milestone Mar 24, 2014
@seancribbs
Copy link
Copy Markdown

riak_dt_orswot uses the compression setting incorrectly. We should wrap the setting in a centralized function so as to reduce copy-pasta.

@lenary
Copy link
Copy Markdown
Contributor Author

lenary commented Apr 14, 2014

Going to attack this now, because bored in a class.

@lenary
Copy link
Copy Markdown
Contributor Author

lenary commented Apr 14, 2014

lww-reg and pn-counter will be incompatible with current representations if we use the centralised functions.

What's the status of breaking changes right now?

@russelldb
Copy link
Copy Markdown
Contributor

Status is "do it!" https://www.youtube.com/watch?v=M9-IZ1pNk00

@lenary
Copy link
Copy Markdown
Contributor Author

lenary commented Apr 14, 2014

Actually, after a closer reading, not going to be incompatible for pncounter V2 serialisation (which is the one we aim to upgrade to anyway).

@seancribbs
Copy link
Copy Markdown

👍 786008f

borshop added a commit that referenced this pull request Apr 14, 2014
…where

Make sure all data types use configured compression in t2b/b2t

Reviewed-by: seancribbs
@seancribbs
Copy link
Copy Markdown

@borshop merge

@borshop borshop merged commit 786008f into develop Apr 14, 2014
@borshop borshop deleted the bugfix/lenary/use-compression-everywhere branch April 14, 2014 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants