Don't encode object dot for JS map-reduce#782
Conversation
There is no need to encode the dot for JavaScript map-reduce. It is an internal thing and doesn't need to be exposed.
|
WFM +1. Nice catch. Thanks. |
|
Actually, second thoughts, I think I might have to be smarter and binary encode the dot. What about downgrades? If data is written with a dot, then the node downgraded, this fix won't be there, but the dot still will be. |
|
Yea, I didn't think of downgrade case. We should revisit this after holidays. Merging for now so tests will work in 2.0. |
Don't encode object dot for JS map-reduce
|
@rzezeski can you open an issue to track? On Tue, Dec 24, 2013 at 8:17 AM, Ryan Zezeski notifications@github.comwrote:
Jon Meredith |
|
@jonmeredith We've put a known issue in release notes for the downgrade problem. |
|
Ok, great. It's good to have in both places - issues get reviewed more On Tue, Dec 24, 2013 at 8:41 AM, Sean Cribbs notifications@github.comwrote:
Jon Meredith |
|
its also been added to the kill bill for true N = 3 safety! |
There is no need to encode the dot for JavaScript map-reduce. It is an
internal thing and doesn't need to be exposed.
This fixes #779.
I see 6 eunit failures both on this branch and develop.