Added a worker pool for fullsync sinks.#618
Closed
jonmeredith wants to merge 1 commit into
Closed
Conversation
Although keylisting has a pool for issuing gets, both the AAE and the Keylist strategies serialize writing objects from the sink process. This adds a pool with a default size of 100 shared across all fullsync sinks that make the writes async. No difference in safety properties, neither version checks the response from the put FSM.
Contributor
Author
|
Assigned to Joe. |
Contributor
|
+1 merge. More testing underway, but current tests show worker pool to always be a win: often times making things 150-160% faster. Note: will be ported to 2.0 branch and merged against 2.0 |
Contributor
Author
|
Included in #620 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although keylisting has a pool for issuing gets, both the
AAE and the Keylist strategies serialize writing objects
from the sink process. This adds a pool with a default size
of 100 shared across all fullsync sinks that make the writes async.
No difference in safety properties, neither version checks
the response from the put FSM.