Enhance/krab/cluster realtime rebalance otp#632
Closed
lixen wants to merge 30 commits into
Closed
Conversation
This implementes riak_core_cluster_serv {1,1}
with new membership function on the server side
to give list of {node(), {IP,Port} | unreachable}
for *all* members of remote cluster. Nodes for
which the cluster_serv cannot RPC to the given
node yield ‘unreachable’ in stead of an IP/Port.
Use new all_members message if remote is 1,1+ For 1,0 emulate new semantics by keeping old IP:PORTs around until cluster_mgr restart. Implement new seeded sort+shuffle for result of calling cluster_mgr:get_ipaddrs_of_cluster/1.
The first tells the caller the address currently connected to. The second tells the rtsource_conn to try (if possible) to switch to an alternative connection.
Contributor
|
aka RIAK-1181 - will smart commits work it out... |
Possible to lose some addresses when ConnectedAddr are early in the list.
[{"127.0.0.1",10106},{"127.0.0.1",10066},{"127.0.0.1",10096},{"127.0.0.1",10076},{"127.0.0.1",10086}], ConnectedAddr: {"127.0.0.1",10066}
[{"127.0.0.1",10106}], UsefulAddrs [{"127.0.0.1",10106}]
Stats function now never returns error code.
Contributor
|
Code looks clean. Could use a rebase. when I rebased it on top of 2.0, it did so cleanly. It passes the appropriate r_t; however there doesn't appear to be any mixed version cluster tests for this. |
|
Thanks for reviewing. We'll add a mixed source cluster test. |
This was referenced Jan 8, 2015
Contributor
Author
|
Is it possible to change target branch for a PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real-time rebalance as described in
https://gist.github.com/krestenkrab/4b1a493469ff28ba5b9d