Added test and fix to coord_serv not giving list for status.#645
Merged
Conversation
Contributor
|
Yes, you are right. It is not used. That seems to have been left behind from the original commit: 989d79a I vote for dropping the check entirely. Thanks for looking at this! |
Contributor
Author
|
The second part to the question is do we want to alter the behavior so it asks all the nodes for stats, or keep it node-local? |
Contributor
Author
|
For posterity: final decision was to defer determining if local only data was valid to later. Fix the error here first (leader existence causing crash). Open a new issue to determine if we should be trying to gather all node's stats. |
Contributor
|
👍 39fa59f I hit rebuild on buildbot as the eunit tests run was incomplete. I'm not sure why. |
borshop
added a commit
that referenced
this pull request
Dec 19, 2014
…-leader Added test and fix to coord_serv not giving list for status. Reviewed-by: engelsanchez
Contributor
|
@borshop merge |
borshop
added a commit
that referenced
this pull request
Dec 19, 2014
…-leader Added test and fix to coord_serv not giving list for status. Reviewed-by: engelsanchez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #615. For those reviewing, this fix may not actually be enough.
While looking through the code, I noticed that the leader node isn't actually used, it's just checked for. After that, the stats gathered are just for the local node. So, is the current behavior correct at all?