Remove partition from purgatory when giving up#648
Merged
Conversation
When a partition has hit the soft exit limit, we add it to the dropped list, but forgot to remove it from the purgatory list. So it may actually be retried later.
Contributor
|
Code looks good, but repl_aee_fullsync test hasn't passed the last couple of times I've tried. currently trying to figure out if it's a problem with my set-up or these changes. |
Contributor
|
👍 31a1657 Got the r_t to pass, as well as dialyzer and eunit. |
Contributor
Author
|
Thanks @lordnull ! Now I guess we need to wait for the builder problem to be fixed to rerun the tests and allow the merge. |
borshop
added a commit
that referenced
this pull request
Dec 24, 2014
Remove partition from purgatory when giving up Reviewed-by: lordnull
Contributor
Author
|
@borshop merge |
borshop
added a commit
that referenced
this pull request
Dec 24, 2014
Remove partition from purgatory when giving up Reviewed-by: lordnull
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a partition has hit the soft exit limit, we add it to the dropped
list, but forgot to remove it from the purgatory list. So it may
actually be retried later.
Also, using a big hammer to silence noisy lager output during EQC tests.
This should fix the cause of this riak_test failure: http://giddyup.basho.com/#/projects/riak_ee/scorecards/115/115-1668-repl_aae_fullsync-centos-6-64/65935/artifacts/1226179
Where you can see partitions being "discared" when they hit the soft limit, but then tried again later. btw, that typo is also fixed by this PR.
/cc @lordnull