Skip to content

Remove partition from purgatory when giving up#648

Merged
borshop merged 2 commits into
2.0from
bugfix/remove-from-purgatory
Dec 24, 2014
Merged

Remove partition from purgatory when giving up#648
borshop merged 2 commits into
2.0from
bugfix/remove-from-purgatory

Conversation

@engelsanchez
Copy link
Copy Markdown
Contributor

When a partition has hit the soft exit limit, we add it to the dropped
list, but forgot to remove it from the purgatory list. So it may
actually be retried later.

Also, using a big hammer to silence noisy lager output during EQC tests.

This should fix the cause of this riak_test failure: http://giddyup.basho.com/#/projects/riak_ee/scorecards/115/115-1668-repl_aae_fullsync-centos-6-64/65935/artifacts/1226179

Where you can see partitions being "discared" when they hit the soft limit, but then tried again later. btw, that typo is also fixed by this PR.

/cc @lordnull

When a partition has hit the soft exit limit, we add it to the dropped
list, but forgot to remove it from the purgatory list. So it may
actually be retried later.
@lordnull
Copy link
Copy Markdown
Contributor

Code looks good, but repl_aee_fullsync test hasn't passed the last couple of times I've tried. currently trying to figure out if it's a problem with my set-up or these changes.

================ repl_aae_fullsync failure stack trace =====================
{{badmatch,{error,notfound}},
 [{repl_aae_fullsync,difference_test,0,
                     [{file,"tests/repl_aae_fullsync.erl"},{line,370}]},
  {repl_aae_fullsync,confirm,0,
                     [{file,"tests/repl_aae_fullsync.erl"},{line,41}]},
  {riak_test_runner,return_to_exit,3,
                    [{file,"src/riak_test_runner.erl"},{line,159}]}]}
============================================================================

@lordnull
Copy link
Copy Markdown
Contributor

👍 31a1657

Got the r_t to pass, as well as dialyzer and eunit.

@engelsanchez
Copy link
Copy Markdown
Contributor Author

Thanks @lordnull ! Now I guess we need to wait for the builder problem to be fixed to rerun the tests and allow the merge.

borshop added a commit that referenced this pull request Dec 24, 2014
Remove partition from purgatory when giving up

Reviewed-by: lordnull
@engelsanchez
Copy link
Copy Markdown
Contributor Author

@borshop merge

borshop added a commit that referenced this pull request Dec 24, 2014
Remove partition from purgatory when giving up

Reviewed-by: lordnull
@borshop borshop merged commit 31a1657 into 2.0 Dec 24, 2014
@seancribbs seancribbs deleted the bugfix/remove-from-purgatory branch April 1, 2015 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants