Conversation
Verify that pagination works for equals queries
This was referenced Jul 27, 2013
ghost
assigned
tests/verify_2i_limit.erl
Outdated
Contributor
There was a problem hiding this comment.
Wrong query used here: Q instead of EqualsQuery. But don't bother fixing, I'm updating the test right now and will push this and other improvements soon.
Added same test for bucket and integer field query. Fixed "Rest" part of PB check using the wrong query variable.
Contributor
|
I've been playing with the test and wrote a couple of additions. Looks good to me 👍 💃 |
Contributor
Author
|
Thanks for the fix and refactor, looks good. |
russelldb
added a commit
that referenced
this pull request
Jul 31, 2013
Test for riak_kv issue gh611
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify that pagination works for equals queries
Tests basho/riak_kv#615