feat(examples): update angular_bazel_architect to version 11#2495
Merged
mattem merged 1 commit intoMar 4, 2021
Merged
Conversation
alan-agius4
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
March 2, 2021 18:26
alan-agius4
force-pushed
the
update-angular_bazel_architect-v11
branch
from
March 2, 2021 18:27
dc600cc to
5a5b04d
Compare
alan-agius4
changed the title
alan-agius4
force-pushed
the
update-angular_bazel_architect-v11
branch
3 times, most recently
from
March 2, 2021 18:34
8c9e6aa to
fc6a31c
Compare
alan-agius4
force-pushed
the
update-angular_bazel_architect-v11
branch
from
March 2, 2021 18:35
fc6a31c to
588e9da
Compare
alan-agius4
force-pushed
the
update-angular_bazel_architect-v11
branch
2 times, most recently
from
March 2, 2021 18:56
3a9de8d to
ad615d3
Compare
alan-agius4
force-pushed
the
update-angular_bazel_architect-v11
branch
from
March 2, 2021 19:02
ad615d3 to
40f5dd3
Compare
alan-agius4
force-pushed
the
update-angular_bazel_architect-v11
branch
from
March 2, 2021 19:13
03d6c00 to
ea294bd
Compare
alan-agius4
force-pushed
the
update-angular_bazel_architect-v11
branch
from
March 2, 2021 19:24
ea294bd to
61c9169
Compare
mattem
approved these changes
Mar 4, 2021
mattem
left a comment
mattem
left a comment
Collaborator
There was a problem hiding this comment.
Awesome 🚀 Reminds me we should update the other Angular example too
Contributor
Author
|
Yeah, If I find sometime I'll try to do them in the coming days. |
This was referenced Mar 8, 2021
saxicek
reviewed
Mar 12, 2021
| const routes: Routes = []; | ||
|
|
||
| @NgModule({imports: [RouterModule.forRoot(routes)], exports: [RouterModule]}) | ||
| @NgModule({imports: [RouterModule.forRoot(routes, { relativeLinkResolution: 'legacy' })], exports: [RouterModule]}) |
Contributor
There was a problem hiding this comment.
I think this should be reverted as there are no routes affected by the related bug IMO.
Contributor
Author
There was a problem hiding this comment.
@saxicek, agreed. Mind opening a PR? thanks.
12 tasks
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.