feat(builtin): add env attribute to nodejs test and binary and run_node helper#2499
Merged
Conversation
mattem
force-pushed
the
feat/env_attr
branch
2 times, most recently
from
March 4, 2021 14:19
392dbb4 to
ab7937a
Compare
Collaborator
Author
|
This is failing on flaky windows tests 😞 |
alexeagle
approved these changes
Mar 5, 2021
alexeagle
left a comment
alexeagle
left a comment
Collaborator
There was a problem hiding this comment.
wow how did we never add this? I keep being disappointed that it's not there :)
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
envproperty in the form a string keyed dict tonodejs_binary,nodejs_testand anything that uses therun_nodehelper (egnpm_package_bin).closes #2497