feat(esbuild): add 'sourcemap' option to configure sourcemap generation#2528
Merged
Conversation
…emaps Inline sourcemaps are useful in debug servers and are easier to correctly set up than external sourcemaps.
Contributor
Author
|
Actually, this doesn't solve the problem I was having with sourcemaps on my dev server, and it doesn't seem to be necessary. Setting I'm still going to open this PR in case this feature is useful, but feel free to close it. |
mattsoulanille
marked this pull request as ready for review
March 14, 2021 03:26
mattsoulanille
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
March 14, 2021 03:26
mattem
reviewed
Mar 14, 2021
Collaborator
|
lgtm thanks! 🙏 |
mattem
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
I'm pretty sure docs are auto-generated from the
dockwarg of attributes. If not, then docs have not been updated.PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, there is no way to have esbuild include inlined sourcemaps in the output bundle.
Issue Number: N/A
What is the new behavior?
By passing
sourcemap_inline = Trueto anesbuildrule namedbundle, sourcemaps will be generated inline inbundle.jsas well as externally inbundle.js.map.Does this PR introduce a breaking change?
Other information
The motivation behind this feature is to make it easier to use esbuild as part of a development server. Inline sourcemaps are easier to correctly set up than external sourcemaps.
The argument is named
sourcemap_inlineinstead ofsourcemapsince it can only add inline sourcemaps to the bundle. We can't let users directly change thesourcemapargument to esbuild, since that argument can turn off the generation of the external sourcemap file, which is a required output of the rule.