fix(builtin): always install source-map-support#2538
Merged
Conversation
We previously did this when patch_module_resolver was the default, because it had some extra (unrelated) logic at the end to install it. When we flipped the default in 3.0, we accidentally dropped the feature. This just reinstates it using the source-map-support/register feature. Similarly to our prior implementation, we just call our own vendored source-map-support so users don't have to think about it. Also fix missing docs for npm_package_bin attrs stdout,stderr,exit_code_out Fixes bazel-contrib#2520
Collaborator
Author
|
@joeljeske this is a followup to our discussion #2448 (comment) |
mattem
approved these changes
Mar 17, 2021
mattem
left a comment
mattem
left a comment
Collaborator
There was a problem hiding this comment.
Test failure looks like a flake on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously did this when patch_module_resolver was the default, because it had some extra (unrelated) logic at the end to install it.
When we flipped the default in 3.0, we accidentally dropped the feature.
This just reinstates it using the source-map-support/register feature.
Similarly to our prior implementation, we just call our own vendored source-map-support so users don't have to think about it.
Also fix missing docs for npm_package_bin attrs stdout,stderr,exit_code_out
Fixes #2520