Revert "fix(builtin): add transitive typings to runfiles provider pro…#3189
Merged
Conversation
…duced by js_library (#2547)" This wasn't actually a fix - it causes type-checking to happen eagerly when a js_library target is built, even if the typings aren't needed. This prevents a transpile-only dev workflow. As noted in the PR #2547 this is easily accomplished in tsc_test by explicitly gathering typings inputs with output_group = types This reverts commit 41117fa.
alexeagle
requested review from
gregmagolan,
mattem and
soldair
as code owners
January 6, 2022 01:14
gregmagolan
approved these changes
Jan 6, 2022
alexeagle
added a commit
that referenced
this pull request
Jan 7, 2022
…duced by js_library (#2547)" (#3189) This wasn't actually a fix - it causes type-checking to happen eagerly when a js_library target is built, even if the typings aren't needed. This prevents a transpile-only dev workflow. As noted in the PR #2547 this is easily accomplished in tsc_test by explicitly gathering typings inputs with output_group = types This reverts commit 41117fa.
alexeagle
added a commit
that referenced
this pull request
Jan 8, 2022
…duced by js_library (#2547)" (#3189) This wasn't actually a fix - it causes type-checking to happen eagerly when a js_library target is built, even if the typings aren't needed. This prevents a transpile-only dev workflow. As noted in the PR #2547 this is easily accomplished in tsc_test by explicitly gathering typings inputs with output_group = types This reverts commit 41117fa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…duced by js_library (#2547)"
This wasn't actually a fix - it causes type-checking to happen eagerly
when a js_library target is built, even if the typings aren't needed.
This prevents a transpile-only dev workflow.
As noted in the PR #2547
this is easily accomplished in tsc_test by explicitly gathering typings
inputs with output_group = types
This reverts commit 41117fa.