fix(jasmine): allow cjs specs + add cjs/mjs tests in jasmine_node_test - #3401
Merged
alexeagle merged 1 commit intoApr 8, 2022
Merged
Conversation
jstuder-gh
requested review from
alexeagle,
gregmagolan and
mattem
as code owners
April 8, 2022 22:08
jstuder-gh
force-pushed
the
jasmine_cjs_spec_and_tests
branch
from
April 8, 2022 22:18
95d62c6 to
1f2b43b
Compare
Contributor
Author
|
Fixed formatting (via buildifier) and repushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using jasmine_node_test, currently spec/test files ending with the .cjs extension are not recognized.
Issue Number:
#3400
What is the new behavior?
Spec/test files ending in the .cjs extension will be recognized
Does this PR introduce a breaking change?
Other information
This PR also adds tests for whether .mjs are recognized in jasmine_node_test