Skip to content

feat: expose @nodejs_host//:bin/node without using alias - #3434

Merged
alexeagle merged 1 commit into
stablefrom
nodehost
Apr 29, 2022
Merged

feat: expose @nodejs_host//:bin/node without using alias#3434
alexeagle merged 1 commit into
stablefrom
nodehost

Conversation

@alexeagle

Copy link
Copy Markdown
Collaborator

This makes it possible for repository rules to reliably find a path to a node interpreter using rctx.path,
without having to hard-code any repository name.
Needed to workaround rctx.path not understanding alias, and repository rules not having any toolchain resolution.

@alexeagle
alexeagle requested a review from kormide April 29, 2022 00:13
@gregmagolan

Copy link
Copy Markdown
Collaborator

Should we a 2nd alias repository in this PR with our preferred name

    nodejs_repo_host_os_alias(
        name = name,
        user_node_repository_name = name,
    )

and then remove

    nodejs_repo_host_os_alias(
        name = name + "_host",
        user_node_repository_name = name,
    )

for 6.0?

This makes it possible for repository rules to reliably find a path to a node interpreter using rctx.path,
without having to hard-code any repository name.
Needed to workaround rctx.path not understanding alias, and repository rules not having any toolchain resolution.
@alexeagle
alexeagle merged commit 506eebc into stable Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants