feat(rollup): support esm configurations to be provided - #3435
Merged
alexeagle merged 1 commit intoMay 2, 2022
Conversation
devversion
requested review from
alexeagle,
gregmagolan,
jbedard and
mattem
as code owners
April 29, 2022 11:20
devversion
force-pushed
the
support-esm-rollup-config
branch
3 times, most recently
from
April 29, 2022 13:43
664e162 to
d7b463f
Compare
Collaborator
|
Looks like a lot of unnecessary whitspace changes? |
jbedard
reviewed
Apr 29, 2022
jbedard
reviewed
Apr 29, 2022
devversion
force-pushed
the
support-esm-rollup-config
branch
from
April 29, 2022 17:03
d7b463f to
99c24bc
Compare
jbedard
reviewed
Apr 29, 2022
devversion
force-pushed
the
support-esm-rollup-config
branch
from
April 29, 2022 17:23
99c24bc to
07d2bac
Compare
jbedard
reviewed
Apr 29, 2022
Adds support for ESM (.mjs) configurations when using `@bazel/rollup`. This is useful for using e.g. ESM rollup plugins, or the Angular linker Babel plugin (as of v13+ Angular packages ship as strict ESM).
devversion
force-pushed
the
support-esm-rollup-config
branch
from
April 29, 2022 17:36
07d2bac to
01c3623
Compare
jbedard
approved these changes
Apr 29, 2022
Collaborator
|
Checked that rules_rollup doesn't seem to have the same problem https://github.com/aspect-build/rules_rollup/blob/main/rollup/private/rollup_bundle.bzl#L241 |
1 similar comment
Collaborator
|
Checked that rules_rollup doesn't seem to have the same problem https://github.com/aspect-build/rules_rollup/blob/main/rollup/private/rollup_bundle.bzl#L241 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for ESM (.mjs) configurations when using
@bazel/rollup.This is useful for using e.g. ESM rollup plugins, or the Angular linker
Babel plugin (as of v13+ Angular packages ship as strict ESM).
cc. @JamesHollyer