fix(typescript): correctly process diagnostics in worker mode - #3441
Merged
Conversation
thesayyn
force-pushed
the
ts_worker_mode_diagnostics
branch
from
May 3, 2022 19:53
feba66d to
2c6aab1
Compare
alexeagle
approved these changes
May 3, 2022
alexeagle
left a comment
alexeagle
left a comment
Collaborator
There was a problem hiding this comment.
awesome thank you!
as a followup, if you have time, we ought to have a regression test for failing open in this scary way.
thesayyn
added a commit
that referenced
this pull request
May 10, 2022
thesayyn
added a commit
that referenced
this pull request
May 10, 2022
alexeagle
pushed a commit
that referenced
this pull request
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3440
What is the new behavior?
Does this PR introduce a breaking change?
Other information