fix(examples): fix architect example on m1 - #3447
Merged
Merged
Conversation
kormide
requested review from
alan-agius4,
alexeagle,
gregmagolan,
jbedard and
mattem
as code owners
May 10, 2022 20:38
jbedard
reviewed
May 10, 2022
kormide
force-pushed
the
angular-example-fix
branch
2 times, most recently
from
May 10, 2022 22:55
ccbba76 to
b55e06a
Compare
jbedard
reviewed
May 10, 2022
kormide
force-pushed
the
angular-example-fix
branch
from
May 10, 2022 23:23
b55e06a to
fb0cac2
Compare
jbedard
reviewed
May 10, 2022
| # If you change the `default_docker_image` version, also change the `cache_key` version | ||
| var_1: &default_docker_image circleci/node:12.18.3 | ||
| var_2: &browsers_docker_image circleci/node:12.18.3-browsers | ||
| var_1: &default_docker_image circleci/node:12.22.7 |
Collaborator
There was a problem hiding this comment.
This is a version of node which supports m1?
Collaborator
Author
There was a problem hiding this comment.
The architect e2e rule relies on host's version of chrome. In order for ci to pass I need a matching chrome version in package.json and whatever this docker container contains.
Collaborator
Author
There was a problem hiding this comment.
The version of chrome in the previous container version didn't have an m1 release.
jbedard
approved these changes
May 11, 2022
alexeagle
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The angular architect example is broken on m1. The version of webdriver-manager that was being used had a bug that prevented it from finding the correct url to download chrome drivers on an m1 architecture.
What is the new behavior?
Resolved the correct version of webdriver-manager and updated e2e tests to run using an m1-supported version of chrome.
Does this PR introduce a breaking change?
Other information