Skip to content

also have jsx files as part of being a JS file - #3488

Merged
alexeagle merged 1 commit into
bazel-contrib:stablefrom
maapteh:patch-1
Jun 22, 2022
Merged

also have jsx files as part of being a JS file#3488
alexeagle merged 1 commit into
bazel-contrib:stablefrom
maapteh:patch-1

Conversation

@maapteh

@maapteh maapteh commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

closes #3487

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Maybe its better to have the option to give which file extensions it accepts? Because jsx is since 2015 problematic in its acceptance and not really more then a React syntax. But the same you already did with allowing CJS => #3350

@google-cla

google-cla Bot commented Jun 20, 2022

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

js_library not including .jsx files

2 participants