Skip to content

fix(typescript): remove protobufjs dependency - #3491

Merged
alexeagle merged 1 commit into
bazel-contrib:stablefrom
mgred:remove-protobufjs-deps
Jun 22, 2022
Merged

fix(typescript): remove protobufjs dependency#3491
alexeagle merged 1 commit into
bazel-contrib:stablefrom
mgred:remove-protobufjs-deps

Conversation

@mgred

@mgred mgred commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

protobufjs is not needed anymore by @bazel/typescript

prototbufjs <6.11.3 is also vulnerable according to GHSA-g954-5hwp-pp24

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

@bazel/typescript depends on prototbufjs.

What is the new behavior?

The package does not depend on protobufjs anymore.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

protobufjs is not needed anymore by @bazel/typescript

prototbufjs <6.11.3 is also vulnerable according to

GHSA-g954-5hwp-pp24
@alexeagle
alexeagle marked this pull request as ready for review June 22, 2022 21:39
@alexeagle
alexeagle merged commit d46502d into bazel-contrib:stable Jun 22, 2022
@mgred
mgred deleted the remove-protobufjs-deps branch June 22, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants