fix(builtin): fix an bug where a nodejs_binary would fail to resolve an npm package when the linker is disabled - #3492
Merged
Merged
Conversation
kormide
force-pushed
the
nolinker-bug-fixes
branch
from
June 23, 2022 00:54
3ef3970 to
1872ff9
Compare
alexeagle
approved these changes
Jun 23, 2022
|
|
||
| e2e_integration_test( | ||
| name = "linker_disabled_regression", | ||
| bazel_commands = ["run //subdir:binary"], |
Collaborator
There was a problem hiding this comment.
nit: should this be two-element argv?
Collaborator
Author
There was a problem hiding this comment.
Nope, all usages I see have a full command per string.
kormide
force-pushed
the
nolinker-bug-fixes
branch
4 times, most recently
from
June 23, 2022 01:15
b4ac0b1 to
1b9c80e
Compare
…an npm package when the linker is disabled
kormide
force-pushed
the
nolinker-bug-fixes
branch
from
June 23, 2022 04:33
1b9c80e to
45bd531
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
@gregmagolan
What is the current behavior?
Under a specific set of conditions where the linker is disabled, export_directories_only is false, and you have multiple yarn_installs, npm packages from the subdir node_modules will fail to be resolved.
What is the new behavior?
The bug is fixed.
Does this PR introduce a breaking change?