fix(builtin): remove unnecessary loader script - #3495
Merged
Conversation
kormide
force-pushed
the
remove-loader-script
branch
2 times, most recently
from
June 27, 2022 22:14
7437190 to
c3f875d
Compare
14 tasks
kormide
force-pushed
the
remove-loader-script
branch
from
June 28, 2022 00:46
c3f875d to
2de3b8a
Compare
Collaborator
Author
|
The test failure is caused by this bug in |
kormide
force-pushed
the
remove-loader-script
branch
from
June 29, 2022 00:09
2de3b8a to
6960fdc
Compare
Collaborator
Author
|
Added a patch for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This is a reincarnation of #3493, and related to #3277.
ESM scripts couldn't be used with
nodejs_binarywhen--nobazel_run_linkerwas set. This is because the loader script is always a.cjsfile and fails when it tries to load an mjs entrypoint.What is the new behavior?
Remove the loader script as it no longer seems to be necessary.
Note that loading third-party dependencies in an esm script when the linker is disabled does not work as our require patch only applies to the cjs loader and not the mjs loader. However this change still provides incremental benefit as you can run an mjs script with no dependencies.
A solution that people can use to load third-party deps is to provide a custom loader using node's
--loaderoption.Does this PR introduce a breaking change?