fix(concatjs): sync with internal change to ensure it works with tsickle host - #3508
Closed
devversion wants to merge 1 commit into
Closed
fix(concatjs): sync with internal change to ensure it works with tsickle host#3508devversion wants to merge 1 commit into
tsickle host#3508devversion wants to merge 1 commit into
Conversation
…ckle` host Tsickle now requires a `generateExtraSuppressions` public property on the TS host. This change has been implemented internally but hasn't been synced upstream, making it difficult to update to the latest `tsickle` externally.
devversion
requested review from
alexeagle,
gregmagolan and
mattem
as code owners
July 25, 2022 13:38
1 task
gregmagolan
approved these changes
Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tsickle now requires a
generateExtraSuppressionspublic property on the TS host. This change has been implemented internally but hasn't been synced upstream, making it difficult to update to the latesttsickleexternally.