fix(builtin): use updated rules_js launcher logic to source RUNFILES#3557
Merged
Conversation
kormide
requested review from
alexeagle,
gregmagolan and
mattem
as code owners
September 27, 2022 00:05
kormide
force-pushed
the
rules_js_launcher
branch
from
September 27, 2022 00:11
e8ff15a to
69ba061
Compare
alexeagle
approved these changes
Sep 27, 2022
gregmagolan
force-pushed
the
rules_js_launcher
branch
3 times, most recently
from
September 27, 2022 16:51
4bea901 to
ee1540b
Compare
kormide
commented
Sep 27, 2022
gregmagolan
force-pushed
the
rules_js_launcher
branch
from
September 27, 2022 17:05
ee1540b to
407481d
Compare
gregmagolan
approved these changes
Sep 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
RUNFILES_MANIFEST_ONLYis always set to1(see https://github.com/angular/angular/pull/47527/files#diff-30590eade0d767af96219fac23a137e7996bff554e9569f1db54ed40be435854R17-R23). This seems like a bug. When runfiles are enabled, during abazel testthe environment varRUNFILESis not set correctly because of it.Separately from addressing the above, the slightly modified launcher logic in
rules_jsalready works around the issue by getting the runfiles directory fromTEST_SRCDIR.What is the new behavior?
Use rules_js updated launcher logic.
Does this PR introduce a breaking change?
Other information