fix(builtin): fix a bug where the launcher produces incorrect runfiles path on windows - #3562
Merged
Merged
Conversation
kormide
requested review from
alexeagle,
gregmagolan and
mattem
as code owners
September 27, 2022 23:12
kormide
force-pushed
the
launcher-path-normalize
branch
3 times, most recently
from
September 27, 2022 23:34
31a3ec0 to
44673f7
Compare
Collaborator
Author
|
This is causing more issues. I think I'll need a pair. |
Collaborator
|
lgtm; looks like you just have to update an env test |
Collaborator
Author
|
It's not setting |
gregmagolan
force-pushed
the
launcher-path-normalize
branch
from
September 28, 2022 18:27
44673f7 to
3fd7d50
Compare
…s path on windows
gregmagolan
force-pushed
the
launcher-path-normalize
branch
from
September 28, 2022 18:27
3fd7d50 to
7371cf5
Compare
Collaborator
TL;DR is that |
gregmagolan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.